Martin Peřina has posted comments on this change.

Change subject: core: adding event when host is reconnecting.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/36405/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java:

Line 752:     }
Line 753: 
Line 754:     private void logChangeStatusToConnecting(long timeoutToFence) {
Line 755:         AuditLogableBase auditLogableBase = new 
AuditLogableBase(cachedVds.getId());
Line 756:         AuditLogDirector.log(auditLogableBase, 
AuditLogType.VDS_HOST_RECONNECTING);
Why do we add another audit log message when we already have 
VDS_HOST_NOT_RESPONDING_CONNECTING message in place?
Line 757: 
Line 758:         log.warn("Host '{}' is not responding. It will stay in 
Connecting state for a grace period " +
Line 759:                         "of {} seconds and after that an attempt to 
fence the host will be issued.",
Line 760:                 cachedVds.getName(),


-- 
To view, visit https://gerrit.ovirt.org/36405
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68a9b16564d1bd8f0bb09e1b8bf6afe02baae424
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to