Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: NPE in VmInterfaceInfoPanel ......................................................................
webadmin: NPE in VmInterfaceInfoPanel The AbstractNullableNumberColumn has to be able to process null values but it failed on NPE when the VmNetworkInterface was null (happens on the load of the VM -> network interfaces subtab). Fixed by simple null check - the renderer than renders null as N/A. Change-Id: If0b6e68254eb112ddb45b17eb79772b2af9b6a0e Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/38481/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java index 44aacbc..1fbd063 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java @@ -125,7 +125,7 @@ AbstractNullableNumberColumn<VmNetworkInterface> totalRxColumn = new AbstractNullableNumberColumn<VmNetworkInterface>() { @Override protected Number getRawValue(VmNetworkInterface object) { - return object.getStatistics().getReceivedBytes(); + return object != null ? object.getStatistics().getReceivedBytes() : null; } }; @@ -134,7 +134,7 @@ AbstractNullableNumberColumn<VmNetworkInterface> totalTxColumn = new AbstractNullableNumberColumn<VmNetworkInterface>() { @Override protected Number getRawValue(VmNetworkInterface object) { - return object.getStatistics().getTransmittedBytes(); + return object != null ? object.getStatistics().getTransmittedBytes() : null; } }; -- To view, visit https://gerrit.ovirt.org/38481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0b6e68254eb112ddb45b17eb79772b2af9b6a0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
