Martin Mucha has posted comments on this change. Change subject: core: DI for AuditLoggerDirector ......................................................................
Patch Set 4: yevgeny, I've tried to add remaining, but that seems rather problematic and ugly (without bringing others under DI; namely singletons or classes with all members static). It brings more problems (ugly api) than it solvers. https://gerrit.ovirt.org/38486 So please look at this draft a decide, whether you want such changes in code base or not (for me it seems less evil have more AuditLogDirector instances). I'd rather throw this draft away, and live on with knowledge, that it's not perfect. Also we can try to finish it somehow or throw it away as a whole and no DI for AuditLoggerDirector. -- To view, visit https://gerrit.ovirt.org/33901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifab56339a634234bbc51fa09719fb87b5cc69501 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
