Liran Zelkha has posted comments on this change. Change subject: core: [search] Users: role = * returns nothing / ERROR ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/38502/1//COMMIT_MSG Commit Message: Line 11: does not exist. Line 12: Line 13: This patch adds an infrastructure that allows us to map specific columns that Line 14: exist in the tag tables but not in the regular tables to solve Line 15: this specific scenario, and any future such scenarion. > and any future such scenarion. => and any such future scenario Done Line 16: Line 17: Change-Id: I742877bf4debfdacc44659359c40e9d6d0a99a3b Line 18: Bug-Url: https://bugzilla.redhat.com/1187693 https://gerrit.ovirt.org/#/c/38502/1/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java: Line 47: mVerbs.add(SearchObjects.PROVIDER_OBJ_NAME); Line 48: mVerbs.add(SearchObjects.INSTANCE_TYPE_OBJ_NAME); Line 49: mVerbs.add(SearchObjects.IMAGE_TYPE_OBJ_NAME); Line 50: Line 51: requiresFullTable.put(SearchObjects.VDC_USER_OBJ_NAME + "-ROLE", true); > wouldn't it be better to have the full name as a constant for future use in Done Line 52: Line 53: // vms - vds Line 54: addJoin(SearchObjects.VM_OBJ_NAME, Line 55: "run_on_vds", Line 500: Boolean result = requiresFullTable.containsKey(obj + "-" + fieldName); Line 501: if (result != null && result) { Line 502: return true; Line 503: } Line 504: return false; > IMO more readable as : Done Line 505: } Line 506: Line 507: public String getRelatedTableName(String obj, boolean useTags) { Line 508: if (useTags) { -- To view, visit https://gerrit.ovirt.org/38502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I742877bf4debfdacc44659359c40e9d6d0a99a3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
