Ori Liel has posted comments on this change. Change subject: restapi: Quering FCP unregistered Storage Domains ......................................................................
Patch Set 2: (2 comments) Please update rsdl yaml file as well https://gerrit.ovirt.org/#/c/38512/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java: Line 290: } You can initialize the type more elegantly using a trinary if Line 300: } I'd add and empty else clause with a comment, to show that it's not a developer mistake -- To view, visit https://gerrit.ovirt.org/38512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe2f2afcd0e6e68adbbbb2054c857388acc30a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
