Gilad Chaplik has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 727: if(permSubject.getMessage() != null){
Line 728: addCanDoActionMessage(permSubject.getMessage());
Line 729: }else {
Line 730:
addCanDoActionMessage(VdcBllMessages.USER_NOT_AUTHORIZED_TO_PERFORM_ACTION);
Line 731: }
looks like the code isn't formatted here.
Line 732: return false;
Line 733: }
Line 734: }
Line 735:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java
Line 16: }
Line 17:
Line 18: public PermissionSubject(Guid objectId, VdcObjectType objectType,
ActionGroup actionGroup,
Line 19: VdcBllMessages message) {
Line 20: super();
super of what?
Line 21: this.objectId = objectId;
Line 22: this.ObjectType = objectType;
Line 23: this.actionGroup = actionGroup;
Line 24: this.message = message;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 653:
Line 654: /* VDSM Error that propagates up to the client. See VdcBLLErrors
*/
Line 655: ERROR_GET_STORAGE_DOMAIN_LIST, //
VdcBllErrors.GetStorageDomainListError
Line 656:
Line 657: USER_CANNOT_FORCE_RECONNECT_TO_VM
I would have added a comma in a separate line to avoid this nasty diff (in
future patches).
Line 658: ;
Line 659:
Line 660: public int getValue() {
Line 661: return this.ordinal();
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 2041:
Line 2042: @DefaultStringValue("Migrating a VM in paused status is
unsupported.")
Line 2043: String MIGRATE_PAUSED_VM_IS_UNSUPPORTED();
Line 2044:
Line 2045: @DefaultStringValue("Console connection denied. Another user has
already accessed the console of this VM. The VM should be rebooted to allow
another user to access it, or changed by an admin to not enforce reboot between
users accessing its console.")
shouldn't we use 'Disable strict user checking'?
Line 2046: String USER_CANNOT_FORCE_RECONNECT_TO_VM();
--
To view, visit http://gerrit.ovirt.org/7496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9fadff662f0d63fd27bacfbf7d765917271932d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
