Moti Asayag has uploaded a new change for review. Change subject: engine: Clear eclipse warnings in AsyncTaskManager * Removed dead code * Remove useless warning suppress * Instantiate map with <> ......................................................................
engine: Clear eclipse warnings in AsyncTaskManager * Removed dead code * Remove useless warning suppress * Instantiate map with <> Change-Id: I768f57466b117a289e238221933f6a262d7b64e3 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java 1 file changed, 1 insertion(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/38515/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java index e9bc6ac..8d8250d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java @@ -107,7 +107,7 @@ } public void initAsyncTaskManager() { - tasksInDbAfterRestart = new ConcurrentHashMap(); + tasksInDbAfterRestart = new ConcurrentHashMap<>(); Map<Guid, List<AsyncTask>> rootCommandIdToTasksMap = groupTasksByRootCommandId(coco.getAllAsyncTasksFromDb()); int numberOfCommandsPartiallyExecuted = 0; for (Entry<Guid, List<AsyncTask>> entry : rootCommandIdToTasksMap.entrySet()) { @@ -319,14 +319,6 @@ spmTask.updateTask(failureStatus); } - private static VdcActionType getEndActionType(AsyncTask dbAsyncTask) { - VdcActionType commandType = dbAsyncTask.getActionParameters().getCommandType(); - if (!VdcActionType.Unknown.equals(commandType)) { - return commandType; - } - return dbAsyncTask.getActionType(); - } - public static void removeTaskFromDbByTaskId(Guid taskId) { try { if (CommandCoordinatorUtil.callRemoveTaskFromDbByTaskId(taskId) != 0) { @@ -457,7 +449,6 @@ * @return poolsAsyncTaskMap - Map which contains tasks for each storage * pool id. */ - @SuppressWarnings("unchecked") private Map<Guid, Map<Guid, AsyncTaskStatus>> getSPMsTasksStatuses(Set<Guid> poolsOfActiveTasks) { Map<Guid, Map<Guid, AsyncTaskStatus>> poolsAsyncTaskMap = new HashMap<Guid, Map<Guid, AsyncTaskStatus>>(); -- To view, visit https://gerrit.ovirt.org/38515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I768f57466b117a289e238221933f6a262d7b64e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
