Moti Asayag has uploaded a new change for review. Change subject: engine: Simplify getChildCommandIds(Guid) * Remove local variable * Use typed empty list from Collections. ......................................................................
engine: Simplify getChildCommandIds(Guid) * Remove local variable * Use typed empty list from Collections. Change-Id: I59703183876498db2a4cc157176e87817bd2ef92 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/38520/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java index cd2dbb7..dc4b566 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java @@ -222,11 +222,10 @@ public List<Guid> getChildCommandIds(Guid cmdId) { initChildHierarchy(); - List<Guid> childIds = Collections.EMPTY_LIST; if (childHierarchy.containsKey(cmdId)) { - childIds = childHierarchy.get(cmdId); + return childHierarchy.get(cmdId); } - return childIds; + return Collections.emptyList(); } public List<CommandEntity> getChildCmdsByParentCmdId(Guid cmdId) { -- To view, visit https://gerrit.ovirt.org/38520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I59703183876498db2a4cc157176e87817bd2ef92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
