Alon Bar-Lev has posted comments on this change. Change subject: aaa: Add ability to switch user ......................................................................
Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/38146/4/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginPhase1Servlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginPhase1Servlet.java: Line 29: if (!SSOUtils.versionSupported(request.getParameter(SSOUtils.VERSION))) { Line 30: throw new RuntimeException(String.format("Unsupported engine version %s found in request.", request.getParameter(SSOUtils.VERSION))); Line 31: } Line 32: Line 33: if ("1".equals(request.getParameter("invalidate"))) { better to compare to anything that is not 0 :) Line 34: request.getSession(true).invalidate(); Line 35: } Line 36: Line 37: if (!request.getParameterMap().isEmpty()) { Line 43: } else { Line 44: SSOConfig config = (SSOConfig) request.getServletContext().getAttribute(SSOUtils.SSO_CONFIG); Line 45: String externalParamValue = request.getParameter("external"); Line 46: boolean disableExternal = StringUtils.isEmpty(externalParamValue) ? false : "0".equals(externalParamValue); Line 47: if (config.isEnableExternalAuth() && !disableExternal) { we should have a new parameter if we want to approve this bypass of external. Line 48: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_EXTERNAL_URI); Line 49: } else { Line 50: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_PHASE2_URI); Line 51: } https://gerrit.ovirt.org/#/c/38146/4/backend/manager/modules/welcome/pom.xml File backend/manager/modules/welcome/pom.xml: Line 52 Line 53 Line 54 Line 55 Line 56 - https://gerrit.ovirt.org/#/c/38146/4/backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml: Line 77: <servlet-name>WelcomeServlet</servlet-name> Line 78: <servlet-class>org.ovirt.engine.core.WelcomeServlet</servlet-class> Line 79: <init-param> Line 80: <param-name>sso-switch-user-url</param-name> Line 81: <param-value>/ovirt-engine/sso/login</param-value> are you sure this should be hard coded? Line 82: </init-param> Line 83: </servlet> Line 84: Line 85: <servlet-mapping> -- To view, visit https://gerrit.ovirt.org/38146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b40d6ea34372ea9e2c2017d500051e6f135bfb8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
