Maor Lipchuk has posted comments on this change. Change subject: core: determine whether domain monitoring result is actual ......................................................................
Patch Set 4: Code-Review+2 (3 comments) https://gerrit.ovirt.org/#/c/38039/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 1224: validAndActual I would prefer it to be actualAndValid since valid does not means anything without actual Line 1224: public boolean validAndActual() { Line 1225: return actual() && valid; Line 1226: } Line 1227: Line 1228: public boolean invalidAndActual() { I would prefer it to be actualAndInValid since invalid does not means anything without actual Line 1229: return actual() && !valid; Line 1230: } Line 1231: Line 1232: public boolean actual() {return this != NOT_ACTUAL;} Line 1232: public formatter -- To view, visit https://gerrit.ovirt.org/38039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddbba94d81694bd6cb1ce3648872eb81182a50ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
