Piotr Kliczewski has posted comments on this change. Change subject: gluster: add 'gluster' prefix to getStorageDeviceList method ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38508/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 372: StatusOnlyReturnForXmlRpc glusterVolumeSnapshotConfigSet(String volumeName, String cfgName, String cfgValue); Line 373: Line 374: StatusOnlyReturnForXmlRpc glusterSnapshotConfigSet(String cfgName, String cfgValue); Line 375: Line 376: StorageDeviceListReturnForXmlRpc getGlusterStorageDeviceList(); Looking at other methods I can see that all gluster related starts with 'gluster' word. I do not like how we distinguish gluster methods but this is the convention that was there so I think that we should follow. What do you think about using glusterStorageDeviceList? Line 377: -- To view, visit https://gerrit.ovirt.org/38508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053fd11c2c8b8ef3faddcfb1660c55a1cbf56bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
