Oved Ourfali has posted comments on this change. Change subject: engine: Add type argument to CommandBase references ......................................................................
Patch Set 2: Code-Review+2 (1 comment) minor question. https://gerrit.ovirt.org/#/c/38516/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java: Line 63: * Ids of entities to be associated with task Line 64: * @return Guid of the created task. Line 65: */ Line 66: public Guid createTask(Guid taskId, Line 67: CommandBase<?> command, why the indentation change? Line 68: AsyncTaskCreationInfo asyncTaskCreationInfo, Line 69: VdcActionType parentCommand, Line 70: String description, Line 71: Map<Guid, VdcObjectType> entitiesMap) { -- To view, visit https://gerrit.ovirt.org/38516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4eb0f992a7be99ee7dc9e4a4b0c887d007c9654 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
