Greg Sheremeta has uploaded a new change for review. Change subject: userportal, webadmin: rename TextCellWithTooltip -> TextCell ......................................................................
userportal, webadmin: rename TextCellWithTooltip -> TextCell (Patch 4d of 12) No logic changes. Just a rename. Change-Id: Ibf859166a879b9018f861c42b748a6a46cc3c9da Signed-off-by: Greg Sheremeta <[email protected]> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DiskContainersCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/EditTextCellWithTooltip.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StorageDomainsCell.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractEditTextColumnWithTooltip.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumn.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java 11 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/38609/1 diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml b/frontend/webadmin/modules/gwt-common/exclude-filters.xml index 3cd65a9..0e54898 100644 --- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml +++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml @@ -175,7 +175,7 @@ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" /> </Match> <Match> - <Class name="org.ovirt.engine.ui.common.widget.table.cell.TextCellWithTooltip" /> + <Class name="org.ovirt.engine.ui.common.widget.table.cell.TextCell" /> <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" /> </Match> diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DiskContainersCell.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DiskContainersCell.java index 75538b3..dcbf250 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DiskContainersCell.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DiskContainersCell.java @@ -6,12 +6,12 @@ import com.google.gwt.dom.client.Element; import com.google.gwt.dom.client.NativeEvent; -public class DiskContainersCell extends TextCellWithTooltip { +public class DiskContainersCell extends TextCell { private String title = ""; //$NON-NLS-1$ public DiskContainersCell() { - super(TextCellWithTooltip.UNLIMITED_LENGTH); + super(TextCell.UNLIMITED_LENGTH); } @Override diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/EditTextCellWithTooltip.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/EditTextCellWithTooltip.java index 5efd745..cca19a9 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/EditTextCellWithTooltip.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/EditTextCellWithTooltip.java @@ -11,9 +11,9 @@ import com.google.gwt.view.client.CellPreviewEvent; /** - * A {@link TextCellWithTooltip} whose text may be edited. + * A {@link TextCell} whose text may be edited. */ -public class EditTextCellWithTooltip extends TextCellWithTooltip implements EventHandlingCell { +public class EditTextCellWithTooltip extends TextCell implements EventHandlingCell { private EditTextCell delegate; diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java index 2e2b57c..2058f1a 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java @@ -10,11 +10,11 @@ /** * This class may be used to display links in cell widgets. It allows the full functionality of a - * {@link TextCellWithTooltip}, and wraps the HTML result of its rendering within link tags. Click events are caught and + * {@link TextCell}, and wraps the HTML result of its rendering within link tags. Click events are caught and * passed to a ValueUpdater. */ @SuppressWarnings("deprecation") -public class LinkCell extends TextCellWithTooltip { +public class LinkCell extends TextCell { public LinkCell(int maxTextLength) { super(maxTextLength, BrowserEvents.MOUSEOVER, BrowserEvents.CLICK); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StorageDomainsCell.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StorageDomainsCell.java index 0ec52b0..4e3f47f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StorageDomainsCell.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StorageDomainsCell.java @@ -6,12 +6,12 @@ import com.google.gwt.dom.client.Element; import com.google.gwt.dom.client.NativeEvent; -public class StorageDomainsCell extends TextCellWithTooltip { +public class StorageDomainsCell extends TextCell { private String title = ""; //$NON-NLS-1$ public StorageDomainsCell() { - super(TextCellWithTooltip.UNLIMITED_LENGTH); + super(TextCell.UNLIMITED_LENGTH); } @Override diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithTooltip.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java similarity index 94% rename from frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithTooltip.java rename to frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java index 2c91b44..ac877ec 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithTooltip.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java @@ -18,7 +18,7 @@ * <p/> * This cell escapes the (String) value when rendering cell HTML. */ -public class TextCellWithTooltip extends AbstractCellWithTooltip<String> implements HasStyleClass { +public class TextCell extends AbstractCellWithTooltip<String> implements HasStyleClass { interface CellTemplate extends SafeHtmlTemplates { @@ -40,11 +40,11 @@ private static CellTemplate template; - public TextCellWithTooltip(int maxTextLength) { + public TextCell(int maxTextLength) { this(maxTextLength, BrowserEvents.MOUSEOVER); } - public TextCellWithTooltip(int maxTextLength, String... consumedEvents) { + public TextCell(int maxTextLength, String... consumedEvents) { super(consumedEvents); this.maxTextLength = maxTextLength; diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractEditTextColumnWithTooltip.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractEditTextColumnWithTooltip.java index 4e16ba6..5d184d0 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractEditTextColumnWithTooltip.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractEditTextColumnWithTooltip.java @@ -1,7 +1,7 @@ package org.ovirt.engine.ui.common.widget.table.column; import org.ovirt.engine.ui.common.widget.table.cell.EditTextCellWithTooltip; -import org.ovirt.engine.ui.common.widget.table.cell.TextCellWithTooltip; +import org.ovirt.engine.ui.common.widget.table.cell.TextCell; import com.google.gwt.cell.client.FieldUpdater; @@ -18,7 +18,7 @@ } public AbstractEditTextColumnWithTooltip(FieldUpdater<T, String> fieldUpdater) { - this(TextCellWithTooltip.UNLIMITED_LENGTH, fieldUpdater); + this(TextCell.UNLIMITED_LENGTH, fieldUpdater); } public AbstractEditTextColumnWithTooltip(int maxTextLength, FieldUpdater<T, String> fieldUpdater) { diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java index 5a77e14..0a4703c 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java @@ -1,7 +1,7 @@ package org.ovirt.engine.ui.common.widget.table.column; import org.ovirt.engine.ui.common.widget.table.cell.LinkCell; -import org.ovirt.engine.ui.common.widget.table.cell.TextCellWithTooltip; +import org.ovirt.engine.ui.common.widget.table.cell.TextCell; import com.google.gwt.cell.client.FieldUpdater; @@ -18,7 +18,7 @@ } public AbstractLinkColumnWithTooltip(FieldUpdater<T, String> fieldUpdater) { - this(TextCellWithTooltip.UNLIMITED_LENGTH, fieldUpdater); + this(TextCell.UNLIMITED_LENGTH, fieldUpdater); } public AbstractLinkColumnWithTooltip(int maxTextLength, FieldUpdater<T, String> fieldUpdater) { diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumn.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumn.java index 3194a0a..5f28ece 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumn.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumn.java @@ -3,11 +3,11 @@ import java.util.Comparator; import org.ovirt.engine.core.common.businessentities.comparators.LexoNumericComparator; -import org.ovirt.engine.ui.common.widget.table.cell.TextCellWithTooltip; +import org.ovirt.engine.ui.common.widget.table.cell.TextCell; /** - * Column for displaying text using {@link TextCellWithTooltip}. + * Column for displaying text using {@link TextCell}. * * @param <T> * Table row data type. @@ -15,14 +15,14 @@ public abstract class AbstractTextColumn<T> extends AbstractSortableColumn<T, String> implements ColumnWithElementId { public AbstractTextColumn() { - this(TextCellWithTooltip.UNLIMITED_LENGTH); + this(TextCell.UNLIMITED_LENGTH); } public AbstractTextColumn(int maxTextLength) { - this(new TextCellWithTooltip(maxTextLength)); + this(new TextCell(maxTextLength)); } - public AbstractTextColumn(TextCellWithTooltip cell) { + public AbstractTextColumn(TextCell cell) { super(cell); } @@ -33,8 +33,8 @@ } @Override - public TextCellWithTooltip getCell() { - return (TextCellWithTooltip) super.getCell(); + public TextCell getCell() { + return (TextCell) super.getCell(); } public void setTitle(String tooltipText) { diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java index 3b4dfe7..e842889 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java @@ -5,7 +5,7 @@ import org.ovirt.engine.ui.common.idhandler.ElementIdHandler; import org.ovirt.engine.ui.common.system.ClientStorage; import org.ovirt.engine.ui.common.utils.ElementIdUtils; -import org.ovirt.engine.ui.common.widget.table.cell.TextCellWithTooltip; +import org.ovirt.engine.ui.common.widget.table.cell.TextCell; import org.ovirt.engine.ui.common.widget.table.column.AbstractTextColumn; import org.ovirt.engine.ui.uicommonweb.UICommand; import org.ovirt.engine.ui.uicommonweb.models.userportal.UserPortalTemplateListModel; @@ -111,7 +111,7 @@ }; getTable().addColumn(nameColumn, commonConstants.templateName(), "350px"); //$NON-NLS-1$ - final TextCellWithTooltip subversionNumberCell = new TextCellWithTooltip(TextCellWithTooltip.UNLIMITED_LENGTH); + final TextCell subversionNumberCell = new TextCell(TextCell.UNLIMITED_LENGTH); final AbstractTextColumn<VmTemplate> subversionNumberColumn = new AbstractTextColumn<VmTemplate>(subversionNumberCell) { @@ -122,7 +122,7 @@ }; table.addColumn(subversionNumberColumn, commonConstants.templateVersion(), "140px"); //$NON-NLS-1$ - final TextCellWithTooltip subversionNameCell = new TextCellWithTooltip(TextCellWithTooltip.UNLIMITED_LENGTH); + final TextCell subversionNameCell = new TextCell(TextCell.UNLIMITED_LENGTH); final AbstractTextColumn<VmTemplate> subversionNameColumn = new AbstractTextColumn<VmTemplate>(subversionNameCell) { @@ -135,7 +135,7 @@ }; table.addColumn(subversionNameColumn, commonConstants.templateVersionName(), "350px"); //$NON-NLS-1$ - final TextCellWithTooltip descriptionCell = new TextCellWithTooltip(TextCellWithTooltip.UNLIMITED_LENGTH); + final TextCell descriptionCell = new TextCell(TextCell.UNLIMITED_LENGTH); final AbstractTextColumn<VmTemplate> descriptionColumn = new AbstractTextColumn<VmTemplate>(descriptionCell) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java index 7c6b9cd..a90b647 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java @@ -10,7 +10,7 @@ import org.ovirt.engine.ui.common.idhandler.ElementIdHandler; import org.ovirt.engine.ui.common.uicommon.model.SearchableDetailModelProvider; import org.ovirt.engine.ui.common.widget.renderer.DiskSizeRenderer; -import org.ovirt.engine.ui.common.widget.table.cell.TextCellWithTooltip; +import org.ovirt.engine.ui.common.widget.table.cell.TextCell; import org.ovirt.engine.ui.common.widget.table.column.AbstractTextColumn; import org.ovirt.engine.ui.uicommonweb.models.quota.QuotaListModel; import org.ovirt.engine.ui.uicommonweb.models.quota.QuotaStorageListModel; @@ -75,8 +75,8 @@ } @Override - public TextCellWithTooltip getCell() { - TextCellWithTooltip TextCellWithTooltip = super.getCell(); + public TextCell getCell() { + TextCell TextCellWithTooltip = super.getCell(); TextCellWithTooltip.setTitle(constants.quotaCalculationsMessage()); return TextCellWithTooltip; } -- To view, visit https://gerrit.ovirt.org/38609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf859166a879b9018f861c42b748a6a46cc3c9da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
