Allon Mureinik has posted comments on this change.
Change subject: core: exception while removing floating disk (#828192)
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 106: final DiskImage diskImage = getDiskImage();
Line 107: final List<Snapshot> updatedSnapshots;
Line 108:
Line 109: try {
Line 110: VM vm = getVmForNonShareableDiskImage(diskImage);
I assume this return null for a sharable disk?
Line 111: // if the disk is not part of a vm (floating), there are
no snapshots to update
Line 112: // so no lock is required.
Line 113: if (isLockOnSnapshotsNeeded && vm!=null) {
Line 114: lockVmSnapshotsWithWait(vm);
--
To view, visit http://gerrit.ovirt.org/7705
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e9ea9599dccbf0ab18609d579c03fd342266378
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
