Alon Bar-Lev has posted comments on this change.

Change subject: database, core: Add the UserProfile entity
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38012/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDAO.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDAO.java:

Line 21:      * @param userId
Line 22:      *            the user id
Line 23:      * @return the user profile, or <code>null</code> if the id was 
invalid
Line 24:      */
Line 25:     UserProfile getByUserId(Guid userId);
> can't a user have more than one profile (means, more than one ssh key, for 
one profile with many attributes, one can be list of ssh public keys.
Line 26: 
Line 27:     /**
Line 28:      * Retrieves all user profiles.
Line 29:      *


-- 
To view, visit https://gerrit.ovirt.org/38012
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idca5769f84d379fd20a184608667a7774cc465c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to