Greg Sheremeta has posted comments on this change. Change subject: webadmin : CheckBoxGroup and DaysOfMonthSelector Widgets ......................................................................
Patch Set 16: (2 comments) Alexander merged this before I could comment again -- but there are two issues I'd like you to address in a follow-up patch. Thanks. https://gerrit.ovirt.org/#/c/37302/16/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DaysOfMonthSelector.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DaysOfMonthSelector.java: Line 21: import com.google.gwt.user.client.ui.HTMLTable.Cell; Line 22: import com.google.gwt.user.client.ui.HasValue; Line 23: import com.google.gwt.user.client.ui.Label; Line 24: Line 25: public class DaysOfMonthSelector extends Composite implements TakesValue<String>, HasValue<String> { Javadoc, please! *Especially important on new Widgets!!* Line 26: Line 27: private static final int DAYS_IN_WEEK = 7; Line 28: private static final int LAST_DAY_OF_MONTH_INDEX = 31; Line 29: private static final UIConstants constants = ConstantsManager.getInstance().getConstants(); https://gerrit.ovirt.org/#/c/37302/16/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelDaysOfMonthSelectorEditor.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelDaysOfMonthSelectorEditor.java: Line 9: import com.google.gwt.editor.client.IsEditor; Line 10: Line 11: public class ListModelDaysOfMonthSelectorEditor extends AbstractValidatedWidgetWithLabel<String, ListModelDaysOfMonthSelector> implements IsEditor<WidgetWithLabelEditor<String, ListModelDaysOfMonthSelectorEditor>> { Line 12: Line 13: /** Javadoc goes above the class name Line 14: * ListModel bound DaysOfMonthSelector editor that uses {@link ListModelDaysOfMonthSelector}. Line 15: */ Line 16: Line 17: private final WidgetWithLabelEditor<String, ListModelDaysOfMonthSelectorEditor> editor; -- To view, visit https://gerrit.ovirt.org/37302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38daa0d2c151eb0e34603488496a8a1ea4719c87 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
