Greg Sheremeta has uploaded a new change for review. Change subject: webadmin: rename CompositeTooltipCell -> CompositeCell ......................................................................
webadmin: rename CompositeTooltipCell -> CompositeCell (Patch 4aq of 12) No functional changes -- just a rename. Change-Id: I1aad9901c21f7447ffb83c8843eeef6da2b52c99 Signed-off-by: Greg Sheremeta <[email protected]> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 3 files changed, 12 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/38740/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeTooltipCell.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeCell.java similarity index 87% rename from frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeTooltipCell.java rename to frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeCell.java index 1212592..7ee1885 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeTooltipCell.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeCell.java @@ -6,19 +6,18 @@ import org.ovirt.engine.ui.common.utils.ElementIdUtils; import com.google.gwt.cell.client.Cell; -import com.google.gwt.cell.client.CompositeCell; import com.google.gwt.cell.client.HasCell; import com.google.gwt.safehtml.shared.SafeHtmlBuilder; import com.google.gwt.user.client.DOM; /** - * A composite cell that supports rendering Element ids via the oVirt Element-ID framework. - * TODO tt add tooltip support - * - * @param <C> - * Cell data type. + * <p> + * Base class for all Cells that would otherwise extend GWT AbstractCell. + * Supports rendering Element ids via the oVirt Element-ID framework. + * </p> + * @param <C> Cell data type. */ -public class CompositeTooltipCell<C> extends CompositeCell<C> implements CellWithElementId<C> { +public class CompositeCell<C> extends com.google.gwt.cell.client.CompositeCell<C> implements CellWithElementId<C> { private final List<HasCell<C, ?>> hasCells; @@ -26,7 +25,7 @@ private String elementIdPrefix = DOM.createUniqueId(); private String columnId; - public CompositeTooltipCell(List<HasCell<C, ?>> hasCells) { + public CompositeCell(List<HasCell<C, ?>> hasCells) { super(hasCells); this.hasCells = hasCells; } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java index 196f583..48ae4ea 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java @@ -15,7 +15,7 @@ import com.google.gwt.safehtml.shared.SafeHtml; import com.google.gwt.safehtml.shared.SafeHtmlBuilder; -public class StatusCompositeCellWithElementId<C> extends CompositeTooltipCell<C> implements CellWithElementId<C> { +public class StatusCompositeCellWithElementId<C> extends CompositeCell<C> implements CellWithElementId<C> { public interface StatusCompositeCellResources extends ClientBundle { @ClientBundle.Source("org/ovirt/engine/ui/common/css/StatusCompositeCell.css") StatusCompositeCellCss statusCompositeCellCss(); diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java index 6085f3b..5b2f114 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java @@ -10,7 +10,7 @@ import org.ovirt.engine.ui.common.widget.HasEditorDriver; import org.ovirt.engine.ui.common.widget.editor.EntityModelCellTable; import org.ovirt.engine.ui.common.widget.table.ActionCellTable; -import org.ovirt.engine.ui.common.widget.table.cell.CompositeTooltipCell; +import org.ovirt.engine.ui.common.widget.table.cell.CompositeCell; import org.ovirt.engine.ui.common.widget.table.column.AbstractColumn; import org.ovirt.engine.ui.common.widget.table.column.AbstractImageResourceColumn; import org.ovirt.engine.ui.common.widget.table.column.AbstractTextColumn; @@ -315,7 +315,7 @@ return new VmTreeItem(table, vm); } - private CompositeTooltipCell<EntityModel> createDiskImageWithMappingComoisiteCell() { + private CompositeCell<EntityModel> createDiskImageWithMappingComoisiteCell() { final AbstractImageResourceColumn<EntityModel> diskImageColumn = new AbstractImageResourceColumn<EntityModel>() { @@ -351,7 +351,7 @@ } - private CompositeTooltipCell<EntityModel> createVmImageWithNameCompositeCell() { + private CompositeCell<EntityModel> createVmImageWithNameCompositeCell() { final AbstractImageResourceColumn<EntityModel> vmImageColumn = new AbstractImageResourceColumn<EntityModel>() { @Override @@ -464,7 +464,7 @@ } -class StyledCompositeCell<T> extends CompositeTooltipCell<T> { +class StyledCompositeCell<T> extends CompositeCell<T> { private final List<HasCell<T, ?>> hasCells; private final StyledProvider<T> styleProvider; -- To view, visit https://gerrit.ovirt.org/38740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1aad9901c21f7447ffb83c8843eeef6da2b52c99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
