Moti Asayag has posted comments on this change. Change subject: core: Make Permissions more friendly to Java Coding Conventions ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38645/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java: Line 57: public Guid getRoleId() { Line 58: return roleId; Line 59: } Line 60: Line 61: public void setAdElementId(Guid value) { while at it, would you like to rename the parameter type from value to adElementId ? Line 62: adElementId = value; Line 63: } Line 64: Line 65: @Override Line 66: public void setId(Guid value) { Line 67: id = value; Line 68: } Line 69: Line 70: public void setRoleId(Guid value) { s/value/RoleId ? Line 71: roleId = value; Line 72: } Line 73: Line 74: public Guid getObjectId() { -- To view, visit https://gerrit.ovirt.org/38645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7571800e3cba302a67960209e676ed374013bf0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
