Eliraz Levi has posted comments on this change. Change subject: webadmin: allowing prefix as mask staticIP conf ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/35145/14/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidationTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidationTest.java: Line 47: public void checkValidErrorMessage() { Line 48: runErrorMesaageCheck(false, true, false, false, ErrorMessage.invalidMask); Line 49: runErrorMesaageCheck(true, false, false, false, ErrorMessage.badPrefixOrNetmaskFormatMessage); Line 50: runErrorMesaageCheck(false, false, false, false, ErrorMessage.badNetmaskFormatMessage); Line 51: runErrorMesaageCheck(false, true, true, false, ErrorMessage.NoError); > Putting a random boolean for the first argument is definitely the right thi Done Line 52: runErrorMesaageCheck(true, false, true, true, ErrorMessage.NoError); Line 53: } Line 54: Line 55: private void runErrorMesaageCheck(boolean isPrefixAllowed, -- To view, visit https://gerrit.ovirt.org/35145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If909eda53a61bda5030c342156a01e53576e77cb Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <[email protected]> Gerrit-Reviewer: Eliraz Levi <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
