Martin Peřina has posted comments on this change. Change subject: restapi: Prepare to rename Permissions to Permission ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/38646/2/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedPermissionsResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedPermissionsResource.java: Line 37: public Permissions list(); Line 38: Line 39: @POST Line 40: @Consumes({ApiMediaType.APPLICATION_XML, ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML}) Line 41: public Response add(org.ovirt.engine.api.model.Permission permission); > i don't think this change is required. When I rename Permissions to Permission in following patch, then there will be naming conflict Line 42: Line 43: @DELETE Line 44: @Path("{id}") Line 45: public Response remove(@PathParam("id") String id); https://gerrit.ovirt.org/#/c/38646/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java: Line 30: import org.ovirt.engine.core.common.queries.VdcQueryType; Line 31: import org.ovirt.engine.core.compat.Guid; Line 32: Line 33: public class BackendAssignedPermissionsResource Line 34: extends AbstractBackendCollectionResource<org.ovirt.engine.api.model.Permission, Permissions> > iirc, Juan once told that we should prefer importing the restapi resource v Bad luck I didn't know this before :-( OK, I will change the whole patch Line 35: implements AssignedPermissionsResource { Line 36: Line 37: private Guid targetId; Line 38: private VdcQueryType queryType; -- To view, visit https://gerrit.ovirt.org/38646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea16b570410a2c74e1ba79231f1c583445826096 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
