Moti Asayag has posted comments on this change.
Change subject: core: Clear current SPM upon "Not SPM" error
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1592:
getVDSReturnValue().setExceptionString(ex.toString());
Line 1593: getVDSReturnValue().setExceptionObject(ex);
Line 1594: getVDSReturnValue().setVdsError(ex.getVdsError());
Line 1595: logException(ex);
Line 1596: if (ex.getVdsError() != null &&
VdcBllErrors.SpmStatusError.equals(ex.getVdsError().getCode())) {
since you're using comparing two enum types, please use == as compare operator
rather have calling the equals method.
Line 1597:
getCurrentIrsProxyData().setCurrentVdsId(Guid.Empty);
Line 1598: }
Line 1599: failover();
Line 1600: } catch (IrsOperationFailedNoFailoverException ex) {
--
To view, visit http://gerrit.ovirt.org/7727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0c9aa8c11ba115580d64c2c64873e059c986bbc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
