Moti Asayag has posted comments on this change.

Change subject: backend: integrate @mask to VdsNetworkInterface
......................................................................


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/35410/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java:

Line 218:                 // save the new network topology to DB
Line 219:                 List<VdsNetworkInterface> ifaces = new 
ArrayList<>(getInterfaces());
Line 220:                 ifaces.addAll(getRemovedBonds().values());
Line 221:                 runVdsCommand(VDSCommandType.CollectVdsNetworkData,
Line 222:                         new 
CollectHostNetworkDataVdsCommandParameters(getVds(), ifaces));
this file should be excluded from this patch. there is no change here.
Line 223: 
Line 224:                 // Update cluster networks (i.e. check if need to 
activate each new network)
Line 225:                 for (Network net : getNetworks()) {
Line 226:                     NetworkClusterHelper.setStatus(getVdsGroupId(), 
net);


-- 
To view, visit https://gerrit.ovirt.org/35410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27141b469edfbc696d8c72279e876d2474753af6
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <[email protected]>
Gerrit-Reviewer: Eliraz Levi <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to