Moti Asayag has uploaded a new change for review. Change subject: engine: Remove redundant warnings suppression ......................................................................
engine: Remove redundant warnings suppression Change-Id: I5b7bfc258a9a298d29a288a8a2313d03edcda47a Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDAODbFacadeImpl.java 2 files changed, 1 insertion(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/38796/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java index 8d722e2..989043c 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java @@ -68,7 +68,6 @@ .executeRead("GettagsBytag_name", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAll() { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource(); @@ -77,7 +76,6 @@ .executeReadList("GetAllFromtags", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForParent(Guid id) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -87,7 +85,6 @@ .executeReadList("GettagsByparent_id", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForUserGroups(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -97,7 +94,6 @@ .executeReadList("GetTagsByUserGroupId", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllUserGroupTagsWithIds(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -107,7 +103,6 @@ .executeReadList("GetUserGroupTagsByTagIds", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForUsers(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -117,7 +112,6 @@ .executeReadList("GetTagsByUserId", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForUsersWithIds(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -127,7 +121,6 @@ .executeReadList("GetUserTagsByTagIds", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForVds(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -137,7 +130,6 @@ .executeReadList("GetTagsByVdsId", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForVdsWithIds(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -147,7 +139,6 @@ .executeReadList("GetVdsTagsByTagIds", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForVm(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -164,7 +155,6 @@ * the Template ids * @return */ - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForTemplate(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -174,7 +164,6 @@ .executeReadList("GetTagsByVmId", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllVmTagsWithIds(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -184,7 +173,6 @@ .executeReadList("GetVmTagsByTagId", TagRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<Tags> getAllForVmPools(String ids) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() @@ -396,7 +384,6 @@ .executeModification("Deletetags_vm_map", parameterSource); } - @SuppressWarnings("unchecked") @Override public List<TagsVmMap> getTagVmMapByVmIdAndDefaultTag(Guid vmid) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("vm_id", vmid); @@ -462,7 +449,6 @@ .executeModification("Deletetags_vm_map", parameterSource); } - @SuppressWarnings("unchecked") @Override public List<TagsVmPoolMap> getVmPoolTagsByVmPoolIdAndAdElementId(Guid vmPoolId, Guid adElementId) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("ad_id", adElementId) diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDAODbFacadeImpl.java index ba39b75..7315caa 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDAODbFacadeImpl.java @@ -10,9 +10,7 @@ /** * <code>VdcOptionDAODbFacadeImpl</code> provides a concrete implementation of {@link VdcOptionDAO} using code - * refactored from {@link DbFacade}. - * - * + * refactored from {@link org.ovirt.engine.core.dal.dbbroker.DbFacade}. */ public class VdcOptionDAODbFacadeImpl extends BaseDAODbFacade implements VdcOptionDAO { @@ -47,7 +45,6 @@ return getCallsHandler().executeRead("GetVdcOptionByName", VdcOptionRowMapper.instance, parameterSource); } - @SuppressWarnings("unchecked") @Override public List<VdcOption> getAll() { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource(); -- To view, visit https://gerrit.ovirt.org/38796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b7bfc258a9a298d29a288a8a2313d03edcda47a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
