Omer Frenkel has posted comments on this change.
Change subject: core:Initialize host name for CDA message(BZ846771)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
Line 161: }
Line 162: return new Pair<Boolean, Map<String,
List<Guid>>>(Boolean.TRUE, resultMap);
Line 163: }
Line 164:
Line 165: private boolean connectedStorageToLunByVdsId(VDS vds, LUNs lun) {
maybe call it connectStorageToLunByVdsId
Line 166: try {
Line 167: return StorageHelperDirector.getInstance()
Line 168: .getItem(getStorageDomain().getstorage_type())
Line 169: .ConnectStorageToLunByVdsId(getStorageDomain(),
vds.getId(), lun, Guid.Empty);
--
To view, visit http://gerrit.ovirt.org/7743
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa40d4671dc99c2126c131fda36c25d8ed4826e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
