Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/38547/10/src/ovirt_host_deploy/constants.py File src/ovirt_host_deploy/constants.py: Line 79: CERTIFICATE_ENROLLMENT_INLINE = 'inline' Line 80: CERTIFICATE_ENROLLMENT_REQUEST = 'request' Line 81: CERTIFICATE_ENROLLMENT_ACCEPT = 'accept' Line 82: HA_AGENT_SERVICE = 'ovirt-ha-agent' Line 83: HA_BROCKER_SERVICE = 'ovirt-ha-broker' these can go into your module, no need to have these here, especially not as codegen Line 84: Line 85: Line 86: @util.export Line 87: @util.codegen https://gerrit.ovirt.org/#/c/38547/10/src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py File src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py: Line 57: """ Line 58: Changes the lock manager from lockd (default) to sanlock. Line 59: Hosted Engine HA relies on sanlock locking for avoiding to launch Line 60: the Hosted Engine VM on different hosts at the same time. Line 61: """ we left with this, the ha should dynamically set libvirt if possible, or we need to also revert this part if disabled. also, if ever vdsm will require to configure this file we will have a race which is not healthy. it seems that you can define domain and per domain setting and assign your vm to that domain instead of effecting entire host. Line 62: self.logger.info(_('Configuring libvirt')) Line 63: old_content = [] Line 64: if os.path.exists(odeploycons.FileLocations.LIBVIRT_QEMU_CONF): Line 65: with open(odeploycons.FileLocations.LIBVIRT_QEMU_CONF, 'r') as f: -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
