Sharad Mishra has posted comments on this change.
Change subject: core: cleanup ActivateVdsCommand
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
Line 87: protected boolean canDoAction() {
Line 88: if (getVds() == null) {
Line 89: return
failCanDoAction(VdcBllMessages.VDS_CANNOT_ACTIVATE_VDS_NOT_EXIST);
Line 90: }
Line 91: if (true && getVds().getstatus() == VDSStatus.Up) {
why 'true'? Just check for getVds().getstatus()
Line 92: return
failCanDoAction(VdcBllMessages.VDS_CANNOT_ACTIVATE_VDS_ALREADY_UP);
Line 93: }
Line 94: return true;
Line 95: }
--
To view, visit http://gerrit.ovirt.org/7740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7e0ec29144e8de15eacec019e2ba9d82782335e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
