Eli Mesika has posted comments on this change. Change subject: core: set cluster for host registration if null ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/37842/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 229: clusterId = cluster.getId(); Line 230: } else { Line 231: // this may occur when the default cluster is removed Line 232: List<VDSGroup> clusters = clusterDao.getAll(); Line 233: if (clusters.isEmpty()) { > this condition should be reverted - else, index-out-of-boundaries-exception Done Line 234: clusterId = clusters.get(0).getId(); Line 235: } Line 236: } Line 237: } https://gerrit.ovirt.org/#/c/37842/5/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 238: HOST_INTERFACE_STATE_UP=Interface ${InterfaceName} on host ${VdsName}, changed state to up Line 239: HOST_INTERFACE_STATE_DOWN=Interface ${InterfaceName} on host ${VdsName}, changed state to down Line 240: HOST_BOND_SLAVE_STATE_UP=Slave ${SlaveName} of bond ${BondName} on host ${VdsName}, changed state to up Line 241: HOST_BOND_SLAVE_STATE_DOWN=Slave ${SlaveName} of bond ${BondName} on host ${VdsName}, changed state to down Line 242: HOST_FAILED_REGISTRATION_INVALID_CLUSTER=No default or valid cluster was found, Host ${VdsName} registration failed > the name should be HOST_REGISTRATION_FAILED_INVALID_CLUSTER per your last u Done Line 243: VDS_DETECTED=Status of host ${VdsName} was set to ${HostStatus}. Line 244: VDS_FAILURE=Host ${VdsName} is non responsive. Line 245: VDS_MAINTENANCE=Host ${VdsName} was switched to Maintenance Mode. Line 246: VDS_MAINTENANCE_MANUAL_HA=Host ${VdsName} was switched to Maintenance mode, but Hosted Engine HA maintenance could not be enabled. Please enable it manually. -- To view, visit https://gerrit.ovirt.org/37842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eda0fe04de8338a49000d62338717584518b153 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
