Daniel Erez has uploaded a new change for review. Change subject: core: AddProviderCommand - validation for specific types ......................................................................
core: AddProviderCommand - validation for specific types * Verify provider existence and support. * Invoke validateAddProvider method to support specific validate implementations (Cinder/Glance/etc). Change-Id: Ie2f7130fcf3904ac771c403f9c81976140659c33 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/38920/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java index 4ffce12..86a7a18 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java @@ -43,8 +43,16 @@ @Override protected boolean canDoAction() { - ProviderValidator validator = new ProviderValidator(getProvider()); - return validate(validator.nameAvailable()); + if (getProvider() == null) { + return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_DOESNT_EXIST); + } + ProviderProxy providerProxy = getProviderProxy(); + if (providerProxy == null) { + return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NOT_SUPPORTED, + String.format("$providerType %1$s", getProvider().getType())); + } + ProviderValidator validator = getProviderProxy().getProviderValidator(); + return validate(validator.nameAvailable()) && validate(validator.validateAddProvider()); } @Override -- To view, visit https://gerrit.ovirt.org/38920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2f7130fcf3904ac771c403f9c81976140659c33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
