Daniel Erez has uploaded a new change for review. Change subject: core: AddProviderCommand - extract to getProviderProxy ......................................................................
core: AddProviderCommand - extract to getProviderProxy AddProviderCommand: extract to getProviderProxy method. Change-Id: I08a1a1a4c637e4fd144dcdd36ffeffe0ab008b26 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/38917/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java index 84ef462..4ffce12 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java @@ -32,6 +32,15 @@ return getProvider().getName(); } + private ProviderProxy providerProxy; + + public ProviderProxy getProviderProxy() { + if (providerProxy == null) { + providerProxy = ProviderProxyFactory.getInstance().create(getProvider()); + } + return providerProxy; + } + @Override protected boolean canDoAction() { ProviderValidator validator = new ProviderValidator(getProvider()); @@ -43,7 +52,7 @@ getProvider().setId(Guid.newGuid()); getDbFacade().getProviderDao().save(getProvider()); - ProviderProxy providerProxy = ProviderProxyFactory.getInstance().create(getProvider()); + ProviderProxy providerProxy = getProviderProxy(); if (providerProxy != null) { providerProxy.onAddition(); } -- To view, visit https://gerrit.ovirt.org/38917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08a1a1a4c637e4fd144dcdd36ffeffe0ab008b26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
