Federico Simoncelli has posted comments on this change. Change subject: core: move getNewMaster to ReconstructMasterDomain ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/28444/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java: Line 27: import org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil; Line 28: Line 29: @NonTransactiveCommandAttribute(forceCompensation = true) Line 30: public class DeactivateStorageDomainWithOvfUpdateCommand<T extends StorageDomainPoolParametersBase> extends Line 31: StorageDomainCommandBase<T> { > this change can't be done, as this command uses the implementation of some My bad, no idea how it got here (probably while I was fixing the electNewMaster part). Line 32: Line 33: public DeactivateStorageDomainWithOvfUpdateCommand(T parameters) { Line 34: this(parameters, null); Line 35: } -- To view, visit https://gerrit.ovirt.org/28444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d342a4c5802cdfbf2c78b50dad4c797c137fe2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
