Alona Kaplan has uploaded a new change for review. Change subject: webadmin: [SetupNetworks] Block drag unmanaged to unassigned(#854005) ......................................................................
webadmin: [SetupNetworks] Block drag unmanaged to unassigned(#854005) https://bugzilla.redhat.com/854005 When you have unmanaged network attached to the host it is possible to drag it towards Unassigned Logical Networks section and then it disappears. Should be blocked with and display an error message. Change-Id: Id95d076128cd68b81e9d40bb909ccec44b6c149d Signed-off-by: Alona Kaplan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/63/7763/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java index 1833cb5..b3c0e53 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java @@ -108,6 +108,12 @@ LogicalNetworkModel network = (LogicalNetworkModel) op1; // op2: null if (network.isAttached() && op2 == null) { + + // not managed + if (!network.isManaged()){ + return NetworkOperation.NULL_OPERATION_UNMANAGED; + } + return NetworkOperation.DETACH_NETWORK; } // op2: nic -- To view, visit http://gerrit.ovirt.org/7763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id95d076128cd68b81e9d40bb909ccec44b6c149d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
