Allon Mureinik has posted comments on this change.

Change subject: core[WIP]:Lost tasks will become unknown in engine.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Looks reasonable, but please, PLEASE, get this verified.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
Line 304:                         .getClass().getName());
Line 305:     }
Line 306: 
Line 307:     /**
Line 308:      * Print log message, Checks if the cachedStatusTask is null, 
(indicating the task was not found in the SPM).
s/Checks/checks
Line 309:      * If so returns {@link AsyncTaskStatusEnum#unknown} status, 
otherwise returns the status as given.<br>
Line 310:      * <br>
Line 311:      *
Line 312:      * @param cachedStatusTask The status from the SPM, or 
<code>null</code> is the task wasn't found in the SPM.


--
To view, visit http://gerrit.ovirt.org/7757
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dc295e71850a7d13aed3449dbf92c6b0ae952ba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to