Maor Lipchuk has posted comments on this change. Change subject: core: StoragePoolValidator - checkStoragePoolNotInStatus ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38901/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StoragePoolValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StoragePoolValidator.java: Line 71: Line 72: return ValidationResult.VALID; Line 73: } Line 74: Line 75: public ValidationResult checkStoragePoolNotInStatus(StoragePoolStatus status) { Probably better to use list of statuses Line 76: if (storagePool.getStatus() != status) { Line 77: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_STATUS_ILLEGAL); Line 78: } Line 79: return ValidationResult.VALID; -- To view, visit https://gerrit.ovirt.org/38901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73034eb6e0e12426a5e4713c5bf8207bdb0ddad1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
