Liron Aravot has posted comments on this change.
Change subject: core: correct handling of FCP lun disks (#854185)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Line 349: LUNs lun = lunDisk.getLun();
Line 350: lun.setLunConnections(new
ArrayList<storage_server_connections>(DbFacade.getInstance()
Line 351:
.getStorageServerConnectionDAO()
Line 352:
.getAllForLun(lun.getLUN_id())));
Line 353: if (!lun.getLunConnections().isEmpty()) {
Done
Line 354: if
(!StorageHelperDirector.getInstance().getItem(lun.getLunConnections().get(0).getstorage_type())
Line 355: .ConnectStorageToLunByVdsId(null, hostId,
lun, getVm().getstorage_pool_id())) {
Line 356: log.infoFormat("Failed to connect a lun disk to
vdsm {0} skiping it", hostId);
Line 357: return false;
....................................................
Commit Message
Line 5: CommitDate: 2012-09-05 12:16:38 +0300
Line 6:
Line 7: core: correct handling of FCP lun disks (#854185)
Line 8:
Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=854141
Done
Line 10:
Line 11: when creating lun disk using FCP, it has no storage server
Line 12: connections. When assuming that the lun has storage server connections
caused to NPE in multiple
Line 13: scenarions, this patch fixes this issue.
--
To view, visit http://gerrit.ovirt.org/7764
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1843a0f3d7f26e49646bf9d414e1858ce46fa167
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
