Maor Lipchuk has posted comments on this change. Change subject: core: OpenStackVolumeProviderProxy and CINDERStorageHelper ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38911/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java: Line 16: Line 17: public class OpenStackVolumeProviderProxy extends AbstractOpenStackStorageProviderProxy<Cinder, OpenStackVolumeProviderProperties, CinderProviderValidator> { Line 18: Line 19: private static final String API_VERSION = "/v2/"; Line 20: public static final String DATE_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSS"; This is not used, please remove Line 21: Line 22: public OpenStackVolumeProviderProxy(Provider<OpenStackVolumeProviderProperties> provider) { Line 23: this.provider = provider; Line 24: } -- To view, visit https://gerrit.ovirt.org/38911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie94f2f8581174cf820d908ba3b51de7564d8a0d4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
