Daniel Erez has posted comments on this change.

Change subject: core: exclude Cinder domains from monitoring
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/38913/5/packaging/dbscripts/storages_san_sp.sql
File packaging/dbscripts/storages_san_sp.sql:

Line 296:    RETURN QUERY SELECT storage_pool_iso_map.*
Line 297:    FROM storage_pool_iso_map
Line 298:    INNER JOIN storage_domain_static on 
storage_pool_iso_map.storage_id = storage_domain_static.id
Line 299:    WHERE storage_pool_id = v_storage_pool_id
Line 300:    AND storage_domain_static.storage_type != 9;
> Please add a comment that we filter out Cinder Storage Domains.
Done
Line 301: 
Line 302: END; $procedure$
Line 303: LANGUAGE plpgsql;
Line 304: 


https://gerrit.ovirt.org/#/c/38913/5/packaging/dbscripts/storages_sp.sql
File packaging/dbscripts/storages_sp.sql:

Line 570:    FROM storage_pool_iso_map
Line 571:    INNER JOIN storage_domain_static on 
storage_pool_iso_map.storage_id = storage_domain_static.id
Line 572:    WHERE storage_pool_id = v_storage_pool_id
Line 573:    AND status = v_status
Line 574:    AND storage_domain_static.storage_type != 9;
> Please add a comment that we filter out Cinder Storage Domains.
Done
Line 575: 
Line 576: END; $procedure$
Line 577: LANGUAGE plpgsql;
Line 578: 


-- 
To view, visit https://gerrit.ovirt.org/38913
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If63e0156ed0c60e265d04f1dbb53f7c48b0e50cb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to