Daniel Erez has posted comments on this change. Change subject: core: adding AbstractOpenStackStorageProviderProxy ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/38872/1//COMMIT_MSG Commit Message: Line 7: core: adding AbstractOpenStackStorageProviderProxy Line 8: Line 9: * Introduced AbstractOpenStackStorageProviderProxy as an abstract Line 10: parent class for storage provider proxies (Glance/Cinder). Line 11: * OpenStackImageProviderProxy now extends the new abstract class. > Also re-factoring part of the methods from OpenStackImageProviderProxy to A Done Line 12: Line 13: Change-Id: Ibff05e2a00e252c30f910e5563c7eda0eb285196 Line 14: Bug-Url: https://bugzilla.redhat.com/1185826 https://gerrit.ovirt.org/#/c/38872/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java: Line 81: addStorageDomain(StorageType.GLANCE, StorageDomainType.Image); Line 82: } Line 83: Line 84: @Override Line 85: public void onRemoval() { > Please also remove onRemoval, since this is already implemented in the new Done Line 86: List<StorageDomain> storageDomains = getDbFacade() Line 87: .getStorageDomainDao().getAllByConnectionId(provider.getId()); Line 88: Line 89: // removing the static and dynamic storage domain entries Line 101: } Line 102: return null; Line 103: } Line 104: Line 105: protected Glance getClient() { > Please add an override annotation, so if the parent class will be deleted w Done Line 106: if (client == null) { Line 107: client = new Glance(getProvider().getUrl() + API_VERSION); Line 108: client.setTokenProvider(getTokenProvider()); Line 109: } Line 298: Line 299: public String getImageUrl(String id) { Line 300: return getProvider().getUrl() + API_VERSION + "/images/" + id; Line 301: } Line 302: > please remove empty line Done -- To view, visit https://gerrit.ovirt.org/38872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibff05e2a00e252c30f910e5563c7eda0eb285196 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
