Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: remove produceLogger method (take 2) ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38387/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java: Line 29 Line 30 Line 31 Line 32 Line 33 I'm nit sure why that's needed, but once that's added it requires to have a non-private constructor, which makes me thinking that the container tries to instantiate the class and have that as a bean in the context. I don't see a good reason for that. Line 85 Line 86 Line 87 Line 88 Line 89 I do not see a good reason for having this be non-private (see my comment above) other than the framework pushes to that. -- To view, visit https://gerrit.ovirt.org/38387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab86145adf4e5856287038c44cd7117564291695 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
