Doron Fediuck has posted comments on this change.
Change subject: engine: Prevent move to empty quota (#845070)
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 381: @Override
Line 382: public boolean validateAndSetQuota() {
Line 383: if
(ImageOperation.Move.equals(getParameters().getOperation())) {
Line 384: // If source and destination are in the same quota - do
nothing and return true
Line 385: if (getImage().getQuotaId() != null &&
getImage().getQuotaId().equals(getQuotaId())) {
Done
Line 386: return true;
Line 387: }
Line 388: if (getQuotaManager()
Line 389: .validateAndSetStorageQuota(getStoragePool(),
--
To view, visit http://gerrit.ovirt.org/7736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab0baf6f583f06197286a976211bada4a0654cb2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
