Tomer Saban has posted comments on this change. Change subject: core: scheduling: VM Affinity Group filter and weight module ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/22793/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java: Line 36: int score; Line 37: for (VDS host : hosts) { Line 38: score = 1; Line 39: if (!acceptableHostsMap.containsKey(host.getId())) { Line 40: score = MaxSchedulerWeight; Why does a host that is not in the acceptableHostsMap get the MaxSchedulerWeight score? Shouldn't it receive the minimal score for not being acceptable host? Line 41: } Line 42: retList.add(new Pair<Guid, Integer>(host.getId(), score)); Line 43: } Line 44: -- To view, visit https://gerrit.ovirt.org/22793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9716523591852635496799412ad387850d6c372d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
