Daniel Erez has posted comments on this change. Change subject: core: AddProviderCommand - validation for specific types ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/38920/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java: Line 43: Line 44: @Override Line 45: protected boolean canDoAction() { Line 46: if (getProvider() == null) { Line 47: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_DOESNT_EXIST); > Were ACTION_TYPE_FAILED_PROVIDER_DOESNT_EXIST already added? yeah, but we need to check it here ensure 'getProviderProxy' won't fail Line 48: } Line 49: ProviderProxy providerProxy = getProviderProxy(); Line 50: if (providerProxy == null) { Line 51: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NOT_SUPPORTED, Line 47: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_DOESNT_EXIST); Line 48: } Line 49: ProviderProxy providerProxy = getProviderProxy(); Line 50: if (providerProxy == null) { Line 51: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NOT_SUPPORTED, > Were ACTION_TYPE_FAILED_PROVIDER_NOT_SUPPORTED already added? no, we only use it here Line 52: String.format("$providerType %1$s", getProvider().getType())); Line 53: } Line 54: ProviderValidator validator = getProviderProxy().getProviderValidator(); Line 55: return validate(validator.nameAvailable()) && validate(validator.validateAddProvider()); -- To view, visit https://gerrit.ovirt.org/38920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f7130fcf3904ac771c403f9c81976140659c33 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
