Maor Lipchuk has posted comments on this change. Change subject: core: adding unsupported domain for datacenter error ......................................................................
Patch Set 5: Code-Review+2 (1 comment) Generally loods good, minor comments on commit message https://gerrit.ovirt.org/#/c/38906/5//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-18 18:42:19 +0200 Line 4: Commit: Daniel Erez <[email protected]> Line 5: CommitDate: 2015-03-19 12:56:29 +0200 Line 6: Line 7: core: adding unsupported domain for datacenter error remove redundant space before the word error. Also consider to rephrase it as :"Adding error message for unsupported domain in datacenter" Line 8: Line 9: Adding error key to VdcBllMessages for unsupported cinder Line 10: storage domain in data center: Line 11: DATA_CENTER_CINDER_STORAGE_NOT_SUPPORTED_IN_CURRENT_VERSION -- To view, visit https://gerrit.ovirt.org/38906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9536655f7713dda9dc3bc1bfa014bc76fd444c11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
