Maor Lipchuk has posted comments on this change.
Change subject: core: test for backend checkDBConnectivity
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 118: checkDBConnectivity();
Line 119: Initialize();
Line 120: }
Line 121:
Line 122: static void checkDBConnectivity() {
Consider to use deceleration of the method accessibilty, for readability
reasons.
Line 123: boolean dbUp = false;
Line 124: long expectedTimeout =
Line 125: System.currentTimeMillis()
Line 126: +
DbFacade.getInstance().getOnStartConnectionTimeout();
--
To view, visit http://gerrit.ovirt.org/4130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icab143177ff26f2af8580fa9b49bb9a6ec9cbfc0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
