Omer Frenkel has posted comments on this change. Change subject: core: made it possible to edit the blank template ......................................................................
Patch Set 5: Code-Review+1 (1 comment) looks ok, just one concern regarding permissions https://gerrit.ovirt.org/#/c/37904/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java: Line 337: @Override Line 338: public List<PermissionSubject> getPermissionCheckSubjects() { Line 339: final List<PermissionSubject> permissionList = super.getPermissionCheckSubjects(); Line 340: Line 341: if (getVmTemplate() != null && !isInstanceType() && !isBlankTemplate()) { will this allow anyone to edit the template? we still need some permission for this Line 342: // host-specific parameters can be changed by administration role only Line 343: if (!(getVmTemplate().getDedicatedVmForVds() == null ? Line 344: getParameters().getVmTemplateData().getDedicatedVmForVds() == null : Line 345: getVmTemplate().getDedicatedVmForVds().equals(getParameters().getVmTemplateData() -- To view, visit https://gerrit.ovirt.org/37904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76f2267ebb36131feadc44a868f6272babe2453e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
