Daniel Erez has posted comments on this change. Change subject: core: OpenStackVolumeProviderProxy and CINDERStorageHelper ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/38911/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java: Line 69: if (storageDomainStatic != null) { Line 70: Provider provider = getDbFacade().getProviderDao().get(new Guid(storageDomainStatic.getStorage())); Line 71: return ProviderProxyFactory.getInstance().create(provider); Line 72: } Line 73: return null; > You wrote in the previous patch set that you can't get null, so why do we e just because we need a return value here... it shouldn't happen in the relevant flow Line 74: } Line 75: Line 76: @Override Line 77: public CinderProviderValidator getProviderValidator() { https://gerrit.ovirt.org/#/c/38911/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java: Line 74: }); Line 75: } Line 76: Line 77: public void activateCinderDomain(Guid storageDomainId, Guid storagePoolId) { Line 78: OpenStackVolumeProviderProxy proxy = OpenStackVolumeProviderProxy.getFromStorageDomainId(storageDomainId); > If that can not be null then the method getFromStorageDomainId should not r the method could return null but it shouldn't happen in this flow Line 79: try { Line 80: proxy.testConnection(); Line 81: updateCinderDomainStatus(storageDomainId, storagePoolId, StorageDomainStatus.Active); Line 82: } catch (VdcBLLException e) { -- To view, visit https://gerrit.ovirt.org/38911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie94f2f8581174cf820d908ba3b51de7564d8a0d4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
