Allon Mureinik has uploaded a new change for review. Change subject: core: AsyncTasksDAOTest: task id in FixturesTool ......................................................................
core: AsyncTasksDAOTest: task id in FixturesTool Moved the existing task ID to the FixturesTool constants repository instead of having it hard-coded in the test. Change-Id: Ic35f5027c1411e797437c386836396e495a8be40 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/7785/1 diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java index f615293..f0183a3 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java @@ -51,7 +51,7 @@ newAsyncTask.setaction_parameters(params); newAsyncTask.setCommandId(Guid.NewGuid()); - existingAsyncTask = dao.get(new Guid("340fd52b-3400-4cdd-8d3f-C9d03704b0aa")); + existingAsyncTask = dao.get(FixturesTool.EXISTING_TASK); } /** diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java index a744fef..a4a7e40 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java @@ -180,6 +180,11 @@ protected static final Guid ENTITY_WITH_TASKS_ID = new Guid("72e3a666-89e1-4005-a7ca-f7548004a9ab"); /** + * Predefined async task + */ + protected static final Guid EXISTING_TASK = new Guid("340fd52b-3400-4cdd-8d3f-C9d03704b0aa"); + + /** * ID of an existing snapshot */ protected static final Guid EXISTING_SNAPSHOT_ID = new Guid("a7bb24df-9fdf-4bd6-b7a9-f5ce52da0f89"); -- To view, visit http://gerrit.ovirt.org/7785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic35f5027c1411e797437c386836396e495a8be40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
