Ramesh N has posted comments on this change. Change subject: gluster: add brick list to add bricks dialog ......................................................................
Patch Set 14: (3 comments) https://gerrit.ovirt.org/#/c/36040/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java: Line 150: else > when will this happen? Else case is not required. Removing now. Line 346: // > If not required, remove it Done https://gerrit.ovirt.org/#/c/36040/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java: Line 307: volumeBrickModel.getShowBricksList().setEntity(true); Line 308: } else { Line 309: volumeBrickModel.getShowBricksList().setIsAvailable(false); Line 310: volumeBrickModel.getShowBricksList().setEntity(false); Line 311: } > This can be moved to VolumeBrickModel to avoid the repetition in VolumeBric Done Line 312: } Line 313: Line 314: setWindow(volumeBrickModel); Line 315: volumeBrickModel.setTitle(ConstantsManager.getInstance().getConstants().addBricksTitle()); -- To view, visit https://gerrit.ovirt.org/36040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e5502cf5a1f551521010214b14414c07f43c2c2 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
