Ori Liel has uploaded a new change for review. Change subject: restapi: Add Non-Existant User - Fail Gracefully ......................................................................
restapi: Add Non-Existant User - Fail Gracefully Change-Id: I27cf1f6a145eea1393d4fe582a6bcf32b5c87691 Signed-off-by: Ori Liel <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/7819/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java index 00db64a..e908780 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java @@ -1,6 +1,7 @@ package org.ovirt.engine.api.restapi.resource; import javax.ws.rs.core.Response; +import javax.ws.rs.core.Response.Status; import org.ovirt.engine.api.model.BaseResource; import org.ovirt.engine.api.model.User; @@ -42,6 +43,11 @@ AdUser adUser = getEntity(AdUser.class, SearchType.AdUser, getSearchPattern(user.getUserName(), domain)); + if (adUser == null) { + return Response.status(Status.BAD_REQUEST) + .entity("No such user: " + user.getUserName() + " in domain " + domain) + .build(); + } AddUserParameters newUser = new AddUserParameters(); newUser.setVdcUser(map(adUser)); return performCreation(VdcActionType.AddUser, newUser, new UserIdResolver(adUser.getUserId()), BaseResource.class); -- To view, visit http://gerrit.ovirt.org/7819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27cf1f6a145eea1393d4fe582a6bcf32b5c87691 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
