Roy Golan has posted comments on this change. Change subject: webadmin: expose permissions creation date ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38400/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java: Line 68: Line 69: AbstractTextColumnWithTooltip<Permissions> creationDateColumn = new AbstractTextColumnWithTooltip<Permissions>() { Line 70: @Override Line 71: public String getValue(Permissions object) { Line 72: return new Date(object.getCreationDate() * 1000).toString(); // GWT doesn't have TimeUnit.java > hmmm, why creationDate * 1000 ? What units the creation date is? And how wi should be in the form of: Mon, 25 Dec 1995 13:30:00 GM the creationDate(I'll add doc if absent) is seconds from epoch. I'll be glad to not using magic numbers in the code but GWT doesn't have a port of TimeUnit.java do we have date utils somewhere? Line 73: } Line 74: }; Line 75: getTable().addColumn(creationDateColumn, constants.permissionsCreationDate(), "300px"); //$NON-NLS-1$ Line 76: creationDateColumn.makeSortable(); -- To view, visit https://gerrit.ovirt.org/38400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c226ed01761ae3836940b5be6f2f2bd82a6f092 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
