Oved Ourfali has posted comments on this change.
Change subject: core: add vdsName to vdsBroker log info (#853883)
......................................................................
Patch Set 2: Looks good to me, approved
(2 inline comments)
minor comments.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
Line 61:
Line 62: @Override
Line 63: protected String getAdditionalInformation() {
Line 64: if (getVds() != null) {
Line 65: return String.format("Vds=%1$s", getVds().getvds_name());
Leave it as it was before, as someone may parse it or something.
Line 66: } else {
Line 67: return super.getAdditionalInformation();
Line 68: }
Line 69: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
Line 48: @Override
Line 49: public String toString() {
Line 50: String AddInfo = getAdditionalInformation();
Line 51: return String.format("%s(%s %s)", super.toString(),
Line 52: (!StringUtils.isEmpty(AddInfo) ? AddInfo + "," : ""),
No need for string utils. But if you want to use it, I think they have a
isNotEmpty method as well.
Line 53: (getParameters() != null ? getParameters().toString()
: "null"));
Line 54: }
Line 55:
Line 56: @Override
--
To view, visit http://gerrit.ovirt.org/7861
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb0589bb5f5e157c04f85e46f6769d66ef98b2d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
